feat: dynamic flow control for batcher #1288
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1288 +/- ##
============================================
+ Coverage 79.23% 79.26% +0.03%
- Complexity 1236 1268 +32
============================================
Files 209 211 +2
Lines 5378 5581 +203
Branches 454 517 +63
============================================
+ Hits 4261 4424 +163
- Misses 938 951 +13
- Partials 179 206 +27
Continue to review full report at Codecov.
|
| @@ -224,6 +294,16 @@ public void close() throws InterruptedException { | |||
| } | |||
| } | |||
|
|
|||
| @InternalApi | |||
There was a problem hiding this comment.
Instead of InternalAPI, this can probably be non-public.
|
|
||
| /** Settings for dynamic flow control */ | ||
| @AutoValue | ||
| @InternalApi |
There was a problem hiding this comment.
Instead of InternalAPI, this can probably be non-public.
| import javax.annotation.Nullable; | ||
|
|
||
| /** Record the statistics of flow control events. */ | ||
| @InternalApi |
There was a problem hiding this comment.
Instead of InternalAPI, this can probably be non-public.
| } | ||
|
|
||
| @InternalApi | ||
| public synchronized void increaseThresholds(long elementSteps, long byteSteps) { |
There was a problem hiding this comment.
Instead of InternalAPI, this can probably be non-public.
Yes the design doc is at go/veneer-dynamic-flow-control. The changes are needed for https://github.com/googleapis/java-bigtable to have dynamic flow control. I've also pinged @igorbernstein2 for a first pass (I don't have access to add reviewers yet), but thank you for taking a look 😃 ! |
mutianf
force-pushed
the
dynamic_flow_control
branch
from
9c7ef74 to
149aad0
Compare
igorbernstein2
added
do not merge
go/veneer-dynamic-flow-control