feat: wrap non-retryable RPCs in retry machinery

[noahdietz]

RPCs that are configured at the client-level to be non-retryable still get wrapped in the retry machinery to ensure features like #1238 that depend on call-time context options still work for non-retryable methods.

In order to ensure that the proper timeout is used by default, the call settings are overridden with setSimpleTimeoutNoRetries.

There are already tests that verify the proper timeout is used for non-retryable RPCs, for example:

gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/TimeoutTest.java

Line 87 in 3fe1db9

public void testNonRetryUnarySettings() {

Fixes #1327

[codecov]

Codecov Report

Merging #1328 (666fc7a) into master (751ccf3) will increase coverage by 0.82%.
The diff coverage is 93.33%.

@@             Coverage Diff              @@
##             master    #1328      +/-   ##
============================================
+ Coverage     80.56%   81.38%   +0.82%     
- Complexity     1332     1340       +8     
============================================
  Files           210      210              
  Lines          5686     5690       +4     
  Branches        519      521       +2     
============================================
+ Hits           4581     4631      +50     
+ Misses          894      850      -44     
+ Partials        211      209       -2     

Impacted Files	Coverage Δ	Complexity Δ
...rc/main/java/com/google/api/gax/rpc/Callables.java	87.27% <93.33%> (+18.64%)	13.00 <3.00> (+1.00)
...le/api/gax/rpc/ServerStreamingAttemptCallable.java	89.56% <0.00%> (+1.73%)	21.00% <0.00%> (+2.00%)
...a/com/google/api/gax/rpc/BatchingCallSettings.java	100.00% <0.00%> (+5.00%)	8.00% <0.00%> (ø%)
.../google/api/gax/batching/NonBlockingSemaphore.java	86.84% <0.00%> (+5.26%)	13.00% <0.00%> (+1.00%)
...java/com/google/api/gax/rpc/PagedCallSettings.java	100.00% <0.00%> (+10.00%)	4.00% <0.00%> (ø%)
...i/gax/retrying/SimpleStreamResumptionStrategy.java	28.57% <0.00%> (+14.28%)	2.00% <0.00%> (+1.00%)
...oogle/api/gax/rpc/ServerStreamingCallSettings.java	93.44% <0.00%> (+22.95%)	8.00% <0.00%> (+1.00%)
...e/api/gax/rpc/RetryingServerStreamingCallable.java	70.00% <0.00%> (+70.00%)	2.00% <0.00%> (+2.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751ccf3...666fc7a. Read the comment docs.

[vam-google]

LGTM

[noahdietz]

going to add a CallablesTest.java because there really should be unit tests for these functions

[noahdietz]

going to add a CallablesTest.java because there really should be unit tests for these functions

Never mind, this code is actually covered by the TimeoutTest file, that's just not in the same package and thus doesn't cover.

[noahdietz]

@igorbernstein2 what are the implications of this change on ServerStreaming callables? Would making all callables wrapped in in the Retry machinery be bad for ServerStreaming?

[noahdietz]

I spoke with Igor offline and he wants to look into how this might affect tracing data for non-retryable RPCs (b.c now the RPC goes through the retry machinery for the single attempt made). He will follow up here with any findings.

He did say this shouldn't be a problem for server streaming RPCs, though.

[noahdietz]

I've added more test classes to verify context & tracer behavior with non-retryable RPCs (and acquire proper code coverage).

[noahdietz]

@igorbernstein2 have you had a chance to verify things locally or see if the tests I added were sufficient WRT Tracing? I'd like to merge this so it can ship with the next release. Thank you!

[noahdietz]

I'm going to submit this PR on Monday.