This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
feat: add setLogicalTimeout helper to RetrySettings #1334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper to the
RetrySettings.Builder
to set a logical call timeout.setLogicalTimeout
takes the giventimeout
and applies it to each of the three timeout settings inRetrySettings
and sets the timeout multiplier to one to keep it constant. In combination with theExponentialRetryAlgorithm
, the first RPC attempt will have the entiretimeout
, and any subsequent attempts will have only the time remaining in thetimeout
. Effectively, users will see their callable "timeout" and return an error after their giventimeout
has been used up. Under the hood, each RPC attempt respects the deadline calculated from the start of the first attempt with the given timeout, and will use as much time as is left.