Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: Build routing header params map with the last entry if multiple entries have the same key. #1729

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

blakeli0
Copy link
Contributor

@blakeli0 blakeli0 commented Jul 8, 2022

fixes: #1728
Guava ImmutableMap.Builder.build() will error out instead of replacing with the last entry if there are multiple entries with the same key, use buildKeepingLast instead of build to fix this issue.

@blakeli0 blakeli0 requested review from a team as code owners July 8, 2022 20:06
@blakeli0 blakeli0 requested a review from alicejli July 8, 2022 20:16
Copy link

@alicejli alicejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for fixing so quickly!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@blakeli0 blakeli0 changed the title fix: Build routing headers params map with the last entry if multiple entries have the same key. fix: Build routing header params map with the last entry if multiple entries have the same key. Jul 8, 2022
@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 878bcf2 into main Jul 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-routing-header branch July 8, 2022 23:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting routing annotations not working
2 participants