Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

chore: Update README about maven migration #1913

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Dec 1, 2022

Add notice about maven migration in README

@lqiu96
Copy link
Contributor Author

lqiu96 commented Dec 1, 2022

Update the CONTRIBUTING.md to remove Gradle references.

@lqiu96 lqiu96 requested a review from suztomo December 2, 2022 15:59
@lqiu96 lqiu96 marked this pull request as ready for review December 2, 2022 15:59
@lqiu96 lqiu96 requested review from a team as code owners December 2, 2022 15:59
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. But the use of quotation markdown looks strange.

@lqiu96
Copy link
Contributor Author

lqiu96 commented Dec 2, 2022

the use of quotation markdown looks strange.

Ok, I can update it just be one large blockquote and try to format some spaces in. The blockquote formatting was weird since it would just put each sentence right after each other (even sentences on a separate line) and I didn't want people to accidentally skip over the maven migration.

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lqiu96 lqiu96 merged commit f0a769c into main Dec 2, 2022
@lqiu96 lqiu96 deleted the main-update_README_maven branch December 2, 2022 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants