Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

WIP: make ClientContext container-only, never initializing #318

Merged
merged 1 commit into from
Jun 5, 2017
Merged

WIP: make ClientContext container-only, never initializing #318

merged 1 commit into from
Jun 5, 2017

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Jun 2, 2017

WIP pending more tests,
but should be good enough for review.
All unit tests pass against both old and regenerated GCJ
but we should integ to make sure.

Adding Neo since a related change broke his code earlier.

WIP pending more tests,
but should be good enough for review.
All unit tests pass against both old and regenerated GCJ
but we should integ to make sure.
@codecov-io
Copy link

codecov-io commented Jun 2, 2017

Codecov Report

Merging #318 into master will increase coverage by 0.3%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #318     +/-   ##
===========================================
+ Coverage     69.81%   70.11%   +0.3%     
- Complexity      355      358      +3     
===========================================
  Files            73       73             
  Lines          1925     1921      -4     
  Branches        157      158      +1     
===========================================
+ Hits           1344     1347      +3     
+ Misses          513      506      -7     
  Partials         68       68
Impacted Files Coverage Δ Complexity Δ
...va/com/google/api/gax/grpc/ChannelAndExecutor.java 75% <ø> (+75%) 3 <0> (+3) ⬆️
.../google/api/gax/core/FixedCredentialsProvider.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...gle/api/gax/grpc/InstantiatingChannelProvider.java 47% <0%> (-0.96%) 9 <0> (ø)
...in/java/com/google/api/gax/grpc/ClientContext.java 100% <100%> (+14.28%) 2 <1> (-1) ⬇️
...n/java/com/google/api/gax/grpc/ClientSettings.java 48.97% <33.33%> (+2.04%) 5 <0> (+1) ⬆️
.../java/com/google/longrunning/OperationsClient.java 93.54% <90%> (-1.91%) 17 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7772e37...259dd74. Read the comment docs.

interceptors.add(new HeaderInterceptor(serviceHeader()));

if (credentialsProvider != null) {

This comment was marked as spam.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -41,7 +41,6 @@
*/
@BetaApi
@AutoValue
@Deprecated

This comment was marked as spam.

@pongad
Copy link
Contributor Author

pongad commented Jun 5, 2017

I tested this against both current GCJ and the one generated by googleapis/gapic-generator#1319. Each test includes mvn test on all projects and mvn verify on pubsub.

I'll merge this, but hold off on toolkit until a gax version bump.

@pongad pongad merged commit 26081fb into googleapis:master Jun 5, 2017
@pongad pongad deleted the client-context branch June 5, 2017 03:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants