Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Document default values for BatchingSettings #639

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Document default values for BatchingSettings #639

merged 2 commits into from
Jan 7, 2019

Conversation

vam-google
Copy link
Contributor

"Fixes" #543

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 5, 2019
@vam-google vam-google requested a review from pongad January 5, 2019 00:25
@codecov-io
Copy link

codecov-io commented Jan 5, 2019 •
edited
Loading

Codecov Report

Merging #639 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #639   +/-   ##
=========================================
  Coverage     74.92%   74.92%           
  Complexity      936      936           
=========================================
  Files           177      177           
  Lines          4111     4111           
  Branches        329      329           
=========================================
  Hits           3080     3080           
  Misses          878      878           
  Partials        153      153
Impacted Files Coverage Δ Complexity Δ
.../com/google/api/gax/batching/BatchingSettings.java 80.95% <ø> (ø) 2 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52a6bd...edbd73b. Read the comment docs.

andreamlin
andreamlin approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@andreamlin andreamlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google vam-google merged commit 2ce5a2f into googleapis:master Jan 7, 2019
@andreamlin andreamlin mentioned this pull request Jan 9, 2019
Merged
@vam-google vam-google mentioned this pull request Jan 10, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreamlin andreamlin andreamlin approved these changes

@pongad pongad Awaiting requested review from pongad

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vam-google @codecov-io @andreamlin @googlebot