-
Notifications
You must be signed in to change notification settings - Fork 88
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Counter does increment first retry (#1601)
* Commented out for testing * Add a bunch of logs * more logs * Save the logs on a branch * Add mechanism for setting retries to 0 * Logging for unique bug * Add a testShouldFailOnThirdError test * move retries counter back * Update code to increment counter on first retry * Remove two tests that are not used * Remove the comment code * Add some error codes * Remove console logs scattered throughout code * Remove logging variables * Remove a couple tests that are run twice * Undo settings changes Also move resolve up * Debugging and finding retries parameter Retries parameter needs to change * Remove comments that are not needed * Simplify diff * Remove comment that is not true anymore * Remove from handler. It is not needed. * Update gax/test/test-application/src/index.ts Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> * Remove a console log --------- Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
- Loading branch information
1 parent
2d0cb03
commit 4b77bf3
Showing
3 changed files
with
87 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters