-
Notifications
You must be signed in to change notification settings - Fork 92
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: minify all common proto JSON files (#1338)
- Loading branch information
1 parent
f64ebc9
commit 7569cc8
Showing
4 changed files
with
127 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Copyright 2022 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import * as assert from 'assert'; | ||
| import {describe, it, beforeEach} from 'mocha'; | ||
| import * as fs from 'fs'; | ||
| import {promises as fsp} from 'fs'; | ||
| import * as rimraf from 'rimraf'; | ||
| import * as path from 'path'; | ||
| import * as util from 'util'; | ||
| import * as minify from '../../tools/minify'; | ||
|
|
||
| const rmrf = util.promisify(rimraf); | ||
| const testDir = path.join(process.cwd(), '.minify-test'); | ||
| const fixturesDir = path.join(__dirname, '..', 'fixtures'); | ||
|
|
||
| describe('minify tool', () => { | ||
| beforeEach(async () => { | ||
| if (fs.existsSync(testDir)) { | ||
| await rmrf(testDir); | ||
| } | ||
| await fsp.mkdir(testDir); | ||
| }); | ||
|
|
||
| it('minifies the proto JSON file', async () => { | ||
| const echoProtoJsonFixture = path.join(fixturesDir, 'echo.json'); | ||
| const echoProtoJson = path.join(testDir, 'echo.json'); | ||
| await fsp.copyFile(echoProtoJsonFixture, echoProtoJson); | ||
| const statBefore = await fsp.stat(echoProtoJson); | ||
| const objectBefore = require(echoProtoJson); | ||
| await minify.main(testDir); | ||
| const statAfter = await fsp.stat(echoProtoJson); | ||
| const objectAfter = require(echoProtoJson); | ||
| const contentAfter = (await fsp.readFile(echoProtoJson)).toString(); | ||
| const parsedObjectAfter = JSON.parse(contentAfter); | ||
| assert(statBefore.size > statAfter.size); | ||
| assert.deepEqual(objectBefore, objectAfter); | ||
| assert.deepEqual(objectBefore, parsedObjectAfter); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| // Copyright 2022 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Minifies proto JSON files under `build/`. | ||
|
|
||
| import {promises as fsp} from 'fs'; | ||
| import * as path from 'path'; | ||
| import * as uglify from 'uglify-js'; | ||
|
|
||
| async function minifyFile(filename: string) { | ||
| const content = (await fsp.readFile(filename)).toString(); | ||
| const output = uglify.minify(content, { | ||
| expression: true, | ||
| compress: false, // we need to keep it valid JSON | ||
| output: {quote_keys: true}, | ||
| }); | ||
| if (output.error) { | ||
| throw output.error; | ||
| } | ||
| await fsp.writeFile(filename, output.code); | ||
| } | ||
|
|
||
| export async function main(directory?: string) { | ||
| const buildDir = directory ?? path.join(process.cwd(), 'build', 'protos'); | ||
| const files = await fsp.readdir(buildDir); | ||
| const jsonFiles = files.filter(file => file.match(/\.json$/)); | ||
| for (const jsonFile of jsonFiles) { | ||
| console.log(`Minifying ${jsonFile}...`); | ||
| await minifyFile(path.join(buildDir, jsonFile)); | ||
| } | ||
| console.log('Minified all proto JSON files successfully.'); | ||
| } | ||
|
|
||
| function usage() { | ||
| console.log(`Usage: node ${process.argv[1]} [directory]`); | ||
| console.log( | ||
| 'Minifies all JSON files in-place in the given directory (non-recursively).' | ||
| ); | ||
| console.log( | ||
| 'If no directory is given, minifies JSON files in ./build/protos.' | ||
| ); | ||
| } | ||
|
|
||
| if (require.main === module) { | ||
| // argv[0] is node.js binary, argv[1] is script path | ||
|
|
||
| if (process.argv[2] === '--help') { | ||
| usage(); | ||
| // eslint-disable-next-line no-process-exit | ||
| process.exit(1); | ||
| } | ||
|
|
||
| main(process.argv[2]); | ||
| } |