Skip to content

Commit

Permalink
Merge branch 'exposeErrorDuringTimeout' of github.com:googleapis/gax-…
Browse files Browse the repository at this point in the history
…nodejs into exposeErrorDuringTimeout
  • Loading branch information
sofisl committed Sep 3, 2024
2 parents e114653 + 48fe7d5 commit 9a67a59
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .release-please-manifest.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"gax": "4.4.0",
"tools": "0.4.5"
"tools": "0.4.6"
}
1 change: 0 additions & 1 deletion gax/src/normalCalls/retries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export function retryable(
}
let retries = 0;
const maxRetries = retry.backoffSettings.maxRetries!;
// let lastTwoErrors = [];
// TODO: define A/B testing values for retry behaviors.

/** Repeat the API call as long as necessary. */
Expand Down
7 changes: 7 additions & 0 deletions tools/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## [0.4.6](https://github.com/googleapis/gax-nodejs/compare/gapic-tools-v0.4.5...gapic-tools-v0.4.6) (2024-08-28)


### Bug Fixes

* **deps:** update dependency protobufjs to v7.4.0 ([#1644](https://github.com/googleapis/gax-nodejs/issues/1644)) ([09cf4de](https://github.com/googleapis/gax-nodejs/commit/09cf4de2765e87466a587230477c81a0007ae795))

## [0.4.5](https://github.com/googleapis/gax-nodejs/compare/gapic-tools-v0.4.4...gapic-tools-v0.4.5) (2024-08-27)


Expand Down
2 changes: 1 addition & 1 deletion tools/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gapic-tools",
"version": "0.4.5",
"version": "0.4.6",
"description": "compiles, updates, and minifies protos",
"main": "build/src/compileProtos.js",
"files": [
Expand Down

0 comments on commit 9a67a59

Please sign in to comment.