Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types for setImmediate calls #1050

Merged
merged 1 commit into from
Jul 9, 2021
Merged

fix: types for setImmediate calls #1050

merged 1 commit into from
Jul 9, 2021

Conversation

alexander-fenster
Copy link
Contributor

The compilation was broken by the new @types/node release that changed something in setImmediate() declaration. I'm fixing types for setImmediate() calls to make it work and getting rid of the spread parameter, since we always know which parameters are being passed to the callback.

@alexander-fenster alexander-fenster requested a review from a team as a code owner July 9, 2021 06:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2021
@alexander-fenster alexander-fenster force-pushed the typescript branch 2 times, most recently from ad0e666 to 7a81843 Compare July 9, 2021 06:55
@alexander-fenster alexander-fenster merged commit a8222eb into master Jul 9, 2021
@alexander-fenster alexander-fenster deleted the typescript branch July 9, 2021 20:08
olavloite added a commit to googleapis/nodejs-spanner that referenced this pull request Jul 12, 2021
googleapis/gax-nodejs#1050 changes the arguments of the response
that are read by the system tests slightly. In the following specific case:
- The RPC returns a long-running operation.
- The result of the operation is Empty.
- The callback is defined as only receiving the long-running operation (and not the Empty response)

Then:
- The length of the arguments array in the callback will be 2 (Operation and IOperation) in gax 2.17.0.
- The length of the arguments array in the callback will be 3 (Operation, IOperation, undefined) in gax 2.17.1

Fixes #1423, #1424, #1425, #1426
skuruppu pushed a commit to googleapis/nodejs-spanner that referenced this pull request Jul 14, 2021
googleapis/gax-nodejs#1050 changes the arguments of the response
that are read by the system tests slightly. In the following specific case:
- The RPC returns a long-running operation.
- The result of the operation is Empty.
- The callback is defined as only receiving the long-running operation (and not the Empty response)

Then:
- The length of the arguments array in the callback will be 2 (Operation and IOperation) in gax 2.17.0.
- The length of the arguments array in the callback will be 3 (Operation, IOperation, undefined) in gax 2.17.1

Fixes #1423, #1424, #1425, #1426
olavloite added a commit to googleapis/nodejs-spanner that referenced this pull request Aug 3, 2021
googleapis/gax-nodejs#1050 changes the arguments of the response
that are read by the system tests slightly. In the following specific case:
- The RPC returns a long-running operation.
- The result of the operation is Empty.
- The callback is defined as only receiving the long-running operation (and not the Empty response)

Then:
- The length of the arguments array in the callback will be 2 (Operation and IOperation) in gax 2.17.0.
- The length of the arguments array in the callback will be 3 (Operation, IOperation, undefined) in gax 2.17.1

Fixes #1423, #1424, #1425, #1426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants