Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanner Instances: should update the metadata failed #1424

Closed
flaky-bot bot opened this issue Jul 10, 2021 · 1 comment
Closed

Spanner Instances: should update the metadata failed #1424

flaky-bot bot opened this issue Jul 10, 2021 · 1 comment
Assignees
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jul 10, 2021

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: 44895d2
buildURL: Build Status, Sponge
status: failed

Test output
operation.on is not a function
TypeError: operation.on is not a function
    at Immediate. (build/system-test/spanner.js:4001:19)
        -> /workspace/system-test/spanner.ts:4985:15
    at processImmediate (internal/timers.js:463:21)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 10, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jul 10, 2021
@olavloite olavloite self-assigned this Jul 12, 2021
olavloite added a commit that referenced this issue Jul 12, 2021
googleapis/gax-nodejs#1050 changes the arguments of the response
that are read by the system tests slightly. In the following specific case:
- The RPC returns a long-running operation.
- The result of the operation is Empty.
- The callback is defined as only receiving the long-running operation (and not the Empty response)

Then:
- The length of the arguments array in the callback will be 2 (Operation and IOperation) in gax 2.17.0.
- The length of the arguments array in the callback will be 3 (Operation, IOperation, undefined) in gax 2.17.1

Fixes #1423, #1424, #1425, #1426
skuruppu pushed a commit that referenced this issue Jul 14, 2021
googleapis/gax-nodejs#1050 changes the arguments of the response
that are read by the system tests slightly. In the following specific case:
- The RPC returns a long-running operation.
- The result of the operation is Empty.
- The callback is defined as only receiving the long-running operation (and not the Empty response)

Then:
- The length of the arguments array in the callback will be 2 (Operation and IOperation) in gax 2.17.0.
- The length of the arguments array in the callback will be 3 (Operation, IOperation, undefined) in gax 2.17.1

Fixes #1423, #1424, #1425, #1426
@flaky-bot
Copy link
Author

flaky-bot bot commented Jul 14, 2021

Test passed for commit 64c2417 (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Jul 14, 2021
olavloite added a commit that referenced this issue Aug 3, 2021
googleapis/gax-nodejs#1050 changes the arguments of the response
that are read by the system tests slightly. In the following specific case:
- The RPC returns a long-running operation.
- The result of the operation is Empty.
- The callback is defined as only receiving the long-running operation (and not the Empty response)

Then:
- The length of the arguments array in the callback will be 2 (Operation and IOperation) in gax 2.17.0.
- The length of the arguments array in the callback will be 3 (Operation, IOperation, undefined) in gax 2.17.1

Fixes #1423, #1424, #1425, #1426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants