fix: get rid of fs-extra #1418
Merged
fix: get rid of fs-extra #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we create an accompanying issue to drop the dependencies (maybe with DROP NODE 14 in the title so we remember)? |
|
Sure! #1419 |
|
Oh no, |
alexander-fenster
changed the title
sofisl
approved these changes
Feb 3, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
🤖 I have created a release *beep* *boop* --- ## [3.5.5](https://github.com/googleapis/gax-nodejs/compare/v3.5.4...v3.5.5) (2023-02-03) ### Bug Fixes * **deps:** Update dependency @grpc/grpc-js to ~1.8.0 ([#1389](https://github.com/googleapis/gax-nodejs/issues/1389)) ([41ad17a](https://github.com/googleapis/gax-nodejs/commit/41ad17a0cc94388417704f929e56fe56498319f5)) * **deps:** Update dependency protobufjs to v7.2.1 ([#1411](https://github.com/googleapis/gax-nodejs/issues/1411)) ([17c7372](https://github.com/googleapis/gax-nodejs/commit/17c7372a0601736227898495ad10fc61907667f8)) * Get rid of fs-extra ([#1418](https://github.com/googleapis/gax-nodejs/issues/1418)) ([082e006](https://github.com/googleapis/gax-nodejs/commit/082e0063227d8f59a9c88416265fdf4acafe8f6f)) * Include Long import in d.ts files ([#1379](https://github.com/googleapis/gax-nodejs/issues/1379)) ([8d9d684](https://github.com/googleapis/gax-nodejs/commit/8d9d6847ff6ee3de4ba4aed8540045cdc9bc6b64)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use the new shiny recursive
fs/promisesmethods such asfs.rmandfs.cp, but at least let's stop usingfs-extrabecause we already importmkdirp,ncp, andrimraf, and that should be enough.As soon as we drop Node 14, we'll drop these three as well.