Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include Long import in d.ts files #1379

Merged
merged 2 commits into from
Feb 3, 2023
Merged

fix: include Long import in d.ts files #1379

merged 2 commits into from
Feb 3, 2023

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Nov 11, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

#1253 only did it for some files, not all.

@SimenB SimenB requested review from a team as code owners November 11, 2022 13:19
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 11, 2022
@SimenB
Copy link
Contributor Author

SimenB commented Jan 27, 2023

@alexander-fenster could you take a look?

@alexander-fenster alexander-fenster added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Feb 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 3, 2023
@alexander-fenster
Copy link
Contributor

Thanks @SimenB, I'm going to merge it now and release.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 3, 2023
@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023
@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Feb 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8d9d684 into googleapis:main Feb 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 3, 2023
@release-please release-please bot mentioned this pull request Feb 3, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 3, 2023
@release-please
chore(main): release 3.5.5 (#1416)
659dc43 
🤖 I have created a release *beep* *boop*
---


## [3.5.5](https://github.com/googleapis/gax-nodejs/compare/v3.5.4...v3.5.5) (2023-02-03)


### Bug Fixes

* **deps:** Update dependency @grpc/grpc-js to ~1.8.0 ([#1389](https://github.com/googleapis/gax-nodejs/issues/1389)) ([41ad17a](https://github.com/googleapis/gax-nodejs/commit/41ad17a0cc94388417704f929e56fe56498319f5))
* **deps:** Update dependency protobufjs to v7.2.1 ([#1411](https://github.com/googleapis/gax-nodejs/issues/1411)) ([17c7372](https://github.com/googleapis/gax-nodejs/commit/17c7372a0601736227898495ad10fc61907667f8))
* Get rid of fs-extra ([#1418](https://github.com/googleapis/gax-nodejs/issues/1418)) ([082e006](https://github.com/googleapis/gax-nodejs/commit/082e0063227d8f59a9c88416265fdf4acafe8f6f))
* Include Long import in d.ts files ([#1379](https://github.com/googleapis/gax-nodejs/issues/1379)) ([8d9d684](https://github.com/googleapis/gax-nodejs/commit/8d9d6847ff6ee3de4ba4aed8540045cdc9bc6b64))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@SimenB SimenB deleted the patch-1 branch February 3, 2023 08:20
@SimenB
Copy link
Contributor Author

SimenB commented Feb 3, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimenB @alexander-fenster @yoshi-kokoro