fix: upgrade proto-loader and add long dev dependency #1253
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2022
product-auto-label
bot
added
size: s
| @@ -73,7 +74,7 @@ | |||
| "ts-loader": "^9.0.0", | |||
| "typescript": "^3.8.3", | |||
| "walkdir": "^0.4.0", | |||
| "webpack": "^4.34.0", | |||
| "webpack": "^5.0.0", | |||
There was a problem hiding this comment.
This sneaked in - I don't think it's related to this PR?
There was a problem hiding this comment.
Right, I got dependency tree error because karmar-webpack ask for 5.0.0. Without this update, it cause fails on npm install.
alexander-fenster
approved these changes
May 5, 2022
This was referenced May 5, 2022
4 tasks
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/gax-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕 #1253 only did it for some files, not all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gax dependency
grpc/proto-loaderswitch long dependency back to 4.x grpc/grpc-node#2114It address #1246