Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use import = to match export = #1247

Closed
wants to merge 1 commit into from
Closed

Conversation

inlined
Copy link

@inlined inlined commented May 4, 2022

It seems like Firestore updated their version of google-gax which broke Cloud Functions for Firebase. As far as I can tell, the problem stems from using a standard import statement to import a module defined with export =. Per documentation, the correct way to import code exported with export = is to use import = require()


Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1246 🦕

@inlined inlined requested a review from a team as a code owner May 4, 2022 00:42
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 4, 2022
@summer-ji-eng
Copy link
Contributor

Thanks @inlined for the PR. We are working on this #1245 now.

@alexander-fenster
Copy link
Contributor

It's much harder than that, because we have this import line in all client libraries (populated by tools/compileProtos.ts). We plan to change that import across the board.

@sofisl
Copy link
Contributor

sofisl commented May 4, 2022

Is this PR OK to close as a duplicate?

@summer-ji-eng
Copy link
Contributor

#1253 should fix the issue. Close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in how "long" is imported breaks Cloud Functions for Firebase
4 participants