Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support field name with period #1148

Merged
merged 5 commits into from
Jan 6, 2022
Merged

fix: support field name with period #1148

merged 5 commits into from
Jan 6, 2022

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Jan 5, 2022 •
edited
Loading

For REST mode, the period . value in the field has been stripped.
For example, the request

{'a.1': 'foo'}

after transcode, it becomes

{'a1': 'foo'}

System-test in firestore

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner January 5, 2022 08:05
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

alexander-fenster
alexander-fenster approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it works :)

@summer-ji-eng summer-ji-eng merged commit 80c9146 into main Jan 6, 2022
@summer-ji-eng summer-ji-eng deleted the snake_camel_period branch January 6, 2022 22:31
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 6, 2022
@release-please
chore: release 2.29.1 (#1151)
2705a20 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.29.1](https://www.github.com/googleapis/gax-nodejs/compare/v2.29.0...v2.29.1) (2022-01-06)


### Bug Fixes

* support field name with period ([#1148](https://www.github.com/googleapis/gax-nodejs/issues/1148)) ([80c9146](https://www.github.com/googleapis/gax-nodejs/commit/80c914628c046392cf45527dc6456d3eb3bfa768))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@summer-ji-eng @alexander-fenster