Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor createByteLengthFunction, warn if fails #1331

Merged
merged 2 commits into from
Aug 29, 2022
Merged

fix: refactor createByteLengthFunction, warn if fails #1331

merged 2 commits into from
Aug 29, 2022

Conversation

alexander-fenster
Copy link
Contributor

  1. Warn (just once) if a function returned by createByteLengthFunction fails.
  2. Make createByteLengthFunction available for fallback scenarios.
  3. Use the proper type for createByteLengthFunction.

@alexander-fenster alexander-fenster requested a review from a team as a code owner August 29, 2022 20:57
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 29, 2022
@alexander-fenster alexander-fenster merged commit d27f7fa into main Aug 29, 2022
@alexander-fenster alexander-fenster deleted the warn-on-serialization-failure branch August 29, 2022 21:16
@release-please release-please bot mentioned this pull request Aug 29, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 29, 2022
@release-please
chore(main): release 3.3.1 (#1330)
b574655 
🤖 I have created a release *beep* *boop*
---


## [3.3.1](v3.3.0...v3.3.1) (2022-08-29)


### Bug Fixes

* **deps:** update dependency protobufjs to v7.1.0 ([#1329](#1329)) ([fc5446e](fc5446e))
* **deps:** update dependency protobufjs-cli to v1.0.1 ([#1328](#1328)) ([b810d37](b810d37))
* refactor createByteLengthFunction, warn if fails ([#1331](#1331)) ([d27f7fa](d27f7fa))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-fenster @ruyadorno