Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Counter does increment first retry #1601

Merged
merged 24 commits into from
May 22, 2024
Merged

fix: Counter does increment first retry #1601

merged 24 commits into from
May 22, 2024

Commits on May 14, 2024

  1. Commented out for testing

    @danieljbruce
    danieljbruce committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c726d2d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Add a bunch of logs

    @danieljbruce
    danieljbruce committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4a4fc53 View commit details
    Browse the repository at this point in the history

  2. more logs

    @danieljbruce
    danieljbruce committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8e75244 View commit details
    Browse the repository at this point in the history

  3. Save the logs on a branch

    @danieljbruce
    danieljbruce committed May 16, 2024
    Configuration menu
    Copy the full SHA
    590fd13 View commit details
    Browse the repository at this point in the history

  4. Add mechanism for setting retries to 0

    @danieljbruce
    danieljbruce committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0ab3ad3 View commit details
    Browse the repository at this point in the history

  5. Logging for unique bug

    @danieljbruce
    danieljbruce committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9299121 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Add a testShouldFailOnThirdError test

    @danieljbruce
    danieljbruce committed May 17, 2024
    Configuration menu
    Copy the full SHA
    aa9fe2e View commit details
    Browse the repository at this point in the history

  2. move retries counter back

    @danieljbruce
    danieljbruce committed May 17, 2024
    Configuration menu
    Copy the full SHA
    26fb2c4 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Update code to increment counter on first retry

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2b964c2 View commit details
    Browse the repository at this point in the history

  2. Remove two tests that are not used

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f1fc02f View commit details
    Browse the repository at this point in the history

  3. Remove the comment code

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4151a59 View commit details
    Browse the repository at this point in the history

  4. Add some error codes

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    de14552 View commit details
    Browse the repository at this point in the history

  5. Remove console logs scattered throughout code

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b87679b View commit details
    Browse the repository at this point in the history

  6. Remove logging variables

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1615aa2 View commit details
    Browse the repository at this point in the history

  7. Remove a couple tests that are run twice

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    dd19e2c View commit details
    Browse the repository at this point in the history

  8. Undo settings changes 

    Also move resolve up
    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3eb195d View commit details
    Browse the repository at this point in the history

  9. Debugging and finding retries parameter 

    Retries parameter needs to change
    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bc84f76 View commit details
    Browse the repository at this point in the history

  10. Remove comments that are not needed

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2eafc35 View commit details
    Browse the repository at this point in the history

  11. Simplify diff

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    994ae29 View commit details
    Browse the repository at this point in the history

  12. Remove comment that is not true anymore

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7a62dce View commit details
    Browse the repository at this point in the history

  13. Remove from handler. It is not needed.

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cb5e750 View commit details
    Browse the repository at this point in the history

  14. Update gax/test/test-application/src/index.ts 

    Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
    @danieljbruce @leahecole
    danieljbruce and leahecole authored May 21, 2024
    Configuration menu
    Copy the full SHA
    48b84f4 View commit details
    Browse the repository at this point in the history

  15. Remove a console log

    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b454fd6 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'counter-does-increment-first-retry' of https://github.c… 

    …om/googleapis/gax-nodejs into counter-does-increment-first-retry
    @danieljbruce
    danieljbruce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0777f15 View commit details
    Browse the repository at this point in the history