Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise error on retryable error when max retries is 0 #1605

Merged
merged 4 commits into from
May 27, 2024

Conversation

leahecole
Copy link
Contributor

@leahecole leahecole commented May 25, 2024

Takes a test that Dan wrote with a possible solution - maybe a fix for b/341297442

Co-authored-by: Daniel Bruce <djbruce@google.com>
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 25, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 25, 2024
@danieljbruce danieljbruce marked this pull request as ready for review May 27, 2024 14:45
@danieljbruce danieljbruce requested review from a team as code owners May 27, 2024 14:45
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2024
Copy link
Contributor

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran linter. LGTM.

@danieljbruce danieljbruce merged commit b4f2f30 into main May 27, 2024
21 checks passed
@danieljbruce danieljbruce deleted the 0maxretries branch May 27, 2024 14:52
@release-please release-please bot mentioned this pull request May 27, 2024
@leahecole leahecole mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants