Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update various dependencies and linting #1622

Merged
merged 4 commits into from
Jun 19, 2024
Merged

fix: update various dependencies and linting #1622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7733e8e
fix: update various dependencies
sofisl Jun 19, 2024
d893a43
retry lint
sofisl Jun 19, 2024
902d685
update linting
sofisl Jun 19, 2024
7c88fac
update linting
sofisl Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gax/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@
"!build/src/**/*.map"
],
"dependencies": {
"@grpc/grpc-js": "~1.10.3",
"@grpc/grpc-js": "^1.10.9",
"@grpc/proto-loader": "^0.7.13",
"@types/long": "^4.0.0",
"abort-controller": "^3.0.0",
"duplexify": "^4.0.0",
"google-auth-library": "^9.3.0",
"node-fetch": "^2.6.1",
"object-hash": "^3.0.0",
"proto3-json-serializer": "^2.0.0",
"proto3-json-serializer": "^2.0.2",
"retry-request": "^7.0.0",
"uuid": "^9.0.1",
"protobufjs": "7.3.0"
"protobufjs": "^7.3.2"
},
"devDependencies": {
"@types/uuid": "^9.0.7",
Expand Down Expand Up @@ -51,7 +51,7 @@
"proxyquire": "^2.0.1",
"pumpify": "^2.0.0",
"rimraf": "^5.0.1",
"sinon": "^17.0.0",
"sinon": "^18.0.0",
"stream-events": "^1.0.4",
"ts-loader": "^8.0.0",
"typescript": "^5.1.6",
Expand Down
2 changes: 1 addition & 1 deletion gax/src/fallbackRest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export function decodeResponse(
ok: boolean,
response: Buffer | ArrayBuffer
): {} {
// eslint-disable-next-line node/no-unsupported-features/node-builtins
// eslint-disable-next-line n/no-unsupported-features/node-builtins
const decodedString = new TextDecoder().decode(response);
const json = JSON.parse(decodedString);
if (!ok) {
Expand Down
4 changes: 2 additions & 2 deletions gax/src/featureDetection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ const features = {
typeof window !== 'undefined' &&
window?.fetch &&
typeof window?.fetch === 'function',
// eslint-disable-next-line node/no-unsupported-features/node-builtins
// eslint-disable-next-line n/no-unsupported-features/node-builtins
textEncoder: typeof TextEncoder !== 'undefined',
// eslint-disable-next-line node/no-unsupported-features/node-builtins
// eslint-disable-next-line n/no-unsupported-features/node-builtins
textDecoder: typeof TextDecoder !== 'undefined',
nodeJS: typeof process !== 'undefined' && process?.versions?.node,
abortController: typeof AbortController !== 'undefined',
Expand Down
4 changes: 2 additions & 2 deletions gax/test/browser-test/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const isDocker = require('is-docker')();
const webpackConfig = require('./webpack.config.js');
webpackConfig.performance = {hints: false};
delete webpackConfig.entry;
// eslint-disable-next-line node/no-missing-require
// eslint-disable-next-line n/no-missing-require
process.env.CHROME_BIN = require('puppeteer').executablePath();

module.exports = function (config) {
Expand All @@ -38,7 +38,7 @@ module.exports = function (config) {
childProcess: {
path: path.relative(
process.cwd(),
// eslint-disable-next-line node/no-missing-require
// eslint-disable-next-line n/no-missing-require
require.resolve('showcase-server/build/src/index.js')
),
args: [],
Expand Down
2 changes: 1 addition & 1 deletion tools/src/compileProtos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ function usage() {
if (require.main === module) {
if (process.argv.length <= 2) {
usage();
// eslint-disable-next-line no-process-exit
// eslint-disable-next-line n/no-process-exit
process.exit(1);
}
// argv[0] is node.js binary, argv[1] is script path
Expand Down
2 changes: 1 addition & 1 deletion tools/src/minify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ if (require.main === module) {

if (process.argv[2] === '--help') {
usage();
// eslint-disable-next-line no-process-exit
// eslint-disable-next-line n/no-process-exit
process.exit(1);
}

Expand Down
2 changes: 1 addition & 1 deletion tools/src/prepublish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ if (require.main === module) {

if (process.argv[2] === '--help') {
usage();
// eslint-disable-next-line no-process-exit
// eslint-disable-next-line n/no-process-exit
process.exit(1);
}

Expand Down
2 changes: 1 addition & 1 deletion tools/src/replaceImportMetaUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// eslint-disable-next-line node/no-extraneous-import
// eslint-disable-next-line n/no-extraneous-import
import {smart} from '@babel/template';
import {Statement} from '@babel/types';
import {Visitor} from '@babel/core';
Expand Down
Loading