Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove duplexify dependency #1694

Closed

Conversation

talentlessguy
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

removes unused duplexify dependency, that was removed in #415

all tests pass, nothing changed

@talentlessguy talentlessguy requested review from a team as code owners January 22, 2025 00:32
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 22, 2025
@talentlessguy
Copy link
Author

pardon me, apparently it was still used, will commit a removal of it in favor of stream.Transform (or stream.Duplex)

@talentlessguy talentlessguy changed the title cleanup: remove unused duplexify dependency cleanup: remove duplexify dependency Jan 29, 2025
@talentlessguy talentlessguy marked this pull request as draft February 1, 2025 20:03
@talentlessguy
Copy link
Author

I'm gonna close this PR, because duplexify is not easy to replace with stream.Duplex since the first allows dynamically setting readable and writable, which is not possible with Node streams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants