fix: includes @types/duplexify in package #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
=======================================
Coverage 92.81% 92.81%
=======================================
Files 26 26
Lines 2769 2769
Branches 72 72
=======================================
Hits 2570 2570
Misses 187 187
Partials 12 12Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
=======================================
Coverage 92.81% 92.81%
=======================================
Files 26 26
Lines 2769 2769
Branches 72 72
=======================================
Hits 2570 2570
Misses 187 187
Partials 12 12Continue to review full report at Codecov.
|
|
I can't say I don't hate it but I guess we have no other good options 😢 |
alexander-fenster
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library uses
duplexify, and returns objects that use types from the@types/duplexifypackage in public interfaces. This is causing issues like the one seen here:googleapis/nodejs-datastore#346