Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: routing header parameters must be urlencoded #521

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

alexander-fenster
Copy link
Contributor

Fixes #520 (cc: @schmidt-sebastian)

Turns out we had our very own implementation of querystring.stringify. Not anymore.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #521 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   82.64%   82.65%   +0.01%     
==========================================
  Files          52       52              
  Lines        3474     3477       +3     
  Branches      267      267              
==========================================
+ Hits         2871     2874       +3     
  Misses        537      537              
  Partials       66       66
Impacted Files Coverage Δ
test/routingHeader.ts 100% <100%> (ø) ⬆️
src/routingHeader.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e398b8b...fc219d8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape header values before sending to GRPC
3 participants