feat: export ServiceConfig #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would also like to export ServiceConfig, so I don't have to pass the full ClientConfig to my utility methods
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
+ Coverage 89.68% 89.68% +<.01%
==========================================
Files 41 41
Lines 7521 7522 +1
Branches 407 407
==========================================
+ Hits 6745 6746 +1
Misses 773 773
Partials 3 3
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would also like to export ServiceConfig, so I don't have to pass the full ClientConfig to my utility methods