fix(compileProtos): mention library protos before common protos

[alexander-fenster]

This one is weird. The order of proto file lookup, both in protoc and in pbjs, depends on the order of folders listed in their -I / -p options (correspondingly). Apparently, in compileProtos script, we first listed the common protos from Gax, and then listed the library protos. Apparently, this does not always work.

Fails:

$ npx pbjs --target json -p ./node_modules/google-gax/protos -p protos -o protos/protos.json proto
s/google/api/servicecontrol/v1/*.proto
no such Type or Enum 'google.logging.type.LogSeverity' in Type .google.api.servicecontrol.v1.LogEntry

Works:

$ npx pbjs --target json -p protos -p ./node_modules/google-gax/protos -o protos/protos.json proto
s/google/api/servicecontrol/v1/*.proto

(the two commands differ only in the order of -p options passed)

I cannot fully explain the failure at this moment, and it might as well be a bug in pbjs, but at least I know how to workaround it by switching an order, and I believe the new order makes more sense (since we should always prioritize the proto file from the API over the common proto file).

[codecov]

Codecov Report

Merging #970 (9e99451) into master (bcecae1) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   88.58%   88.69%   +0.11%     
==========================================
  Files          43       43              
  Lines        7097     7097              
  Branches      612      564      -48     
==========================================
+ Hits         6287     6295       +8     
+ Misses        800      791       -9     
- Partials       10       11       +1     

Impacted Files	Coverage Δ
tools/compileProtos.ts	93.71% <100.00%> (ø)
src/fallback.ts	79.24% <0.00%> (ø)
src/normalCalls/retries.ts	98.72% <0.00%> (+5.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcecae1...9e99451. Read the comment docs.