This repository has been archived by the owner on Mar 20, 2018. It is now read-only.
Fix bundling bug #114
Merged
Fix bundling bug #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per offline discussion, I will investigate about adding more thorough tests for delay threshold-triggered bundling as a follow-up to this PR. See #115 |
Current coverage is 97.16%@@ master #114 diff @@
==========================================
Files 8 8
Lines 599 599
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 582 582
Misses 17 17
Partials 0 0
|
|
LGTM |
Previously, one timer was associated with each Executor. This timer was not reset when it fired, which meant that only a single request could ever be triggered by a delay threshold. This change switches to using one timer per bundle. This correctly allows different bundles to fire under different timers.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, one timer was associated with each Executor. This timer
was not reset when it fired, which meant that only a single request
could ever be triggered by a delay threshold.
This change switches to using one timer per bundle. This correctly
allows different bundles to fire under different timers.
cc: @tbetbetbe @jmuk
Fixes #113