fix: return text when content type is text/*

googleapis · Oct 14, 2023 · f49540c · f49540c
1 parent dd053c7
commit f49540c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/gaxios.ts b/src/gaxios.ts
@@ -402,10 +402,7 @@ export class Gaxios {
         // continue
       }
       return data as {};
-    } else if (
-      contentType.includes('text/plain') ||
-      contentType.includes('text/html')
-    ) {
+    } else if (contentType.match(/^text\//)) {
       return response.text();
     } else {
       // If the content type is something not easily handled, just return the raw data (blob)

diff --git a/test/test.getch.ts b/test/test.getch.ts
@@ -655,6 +655,17 @@ describe('🎏 data handling', () => {
     assert.deepStrictEqual(res.data, body);
   });
 
+  it('should return text when response Content-Type=text/csv', async () => {
+    const body = '"col1","col2"\n"hello","world"';
+    const scope = nock(url)
+      .get('/')
+      .reply(200, body, {'Content-Type': 'text/csv'});
+    const res = await request({url});
+    scope.done();
+    assert.ok(res.data);
+    assert.deepStrictEqual(res.data, body);
+  });
+
   it('should return raw data when Content-Type is unable to be parsed', async () => {
     const body = Buffer.from('hello world', 'utf-8');
     const scope = nock(url)