fix: continue replacing application/x-www-form-urlencoded with application/json #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 98.67% 98.52% -0.15%
==========================================
Files 4 4
Lines 603 612 +9
Branches 104 97 -7
==========================================
+ Hits 595 603 +8
- Misses 8 9 +1
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Mar 24, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
bcoe
added a commit
to googleapis/node-gtoken
that referenced
this pull request
Feb 26, 2021
This is a long standing bug that prevents us from setting content-type in gaxios. Refs: googleapis/google-api-nodejs-client#2003 Refs: googleapis/gaxios#263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we rely on the side effect of application/x-www-form-urlencoded being replaced with application/json somewhere in our stack. This will need to be unraveled and fixed upstream. Also, we will need to treat applying
Content-Typeas a breaking change in the future.