feat: add initial retry delay, and set default to 100ms #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 95.52% 95.53% +0.01%
==========================================
Files 6 6
Lines 670 672 +2
Branches 105 106 +1
==========================================
+ Hits 640 642 +2
Misses 30 30
Continue to review full report at Codecov.
|
sofisl
approved these changes
Sep 14, 2020
bcoe
approved these changes
Sep 14, 2020
bcoe
reviewed
Sep 14, 2020
| await request({ | ||
| url, | ||
| retryConfig: { | ||
| retryDelay: 500, |
There was a problem hiding this comment.
This seems like a nice simple way to write this test for now 👍
I've definitely seen tests like this that add 100+ ms delays add up over time, and lead to a fairly slow test suite... I don't think this will bite us, having a couple smoke tests for retry logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333