-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: drop node 10 from engines list, update typescript to 4.6.3 #477
Conversation
Warning: This pull request is touching the following templated files:
|
There are a bunch of Kokoro files still referencing Node 8 and Node 10. Can these be safely updated? |
@@ -9,7 +9,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
node: [10, 12, 14, 16] | |||
node: [12, 14, 16] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OwlBot seems upset that I touched this. Should I have left this alone?
@ddelgrosso1, everything looks good here except that the post-processor doesn't seem to be picking up the new ci.yaml file. It should look like: |
The other question I have is for @bcoe, should these be build! or feat! |
@sofisl the reason the post processor didn't run is because I work from my own fork. I always have to manually trigger it. I've updated the 2 .yml files you called out. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕