-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Do not treat Buffers as JSON by default #621
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
58c7dc2
feat!: Upgrade to `node-fetch` v3
d-goog f8570d9
Merge branch 'main' into upgrade-node-fetch
danielbankhead 7fd2a95
refactor: Use native `FormData` in testing
d-goog 0cc7856
Merge branch 'upgrade-node-fetch' of github.com:googleapis/gaxios int…
d-goog a61cfa5
feat!: Improve spec compliance
d-goog 35a73b1
test(temp): Run 18+
d-goog e7addeb
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 9816229
feat: Improve types, streamline, and standardize
d-goog 7315442
feat!: Do Not Treat Buffers as JSON By Default
d-goog 93bf4a8
Merge branch 'main' of github.com:googleapis/gaxios into upgrade-node…
d-goog 273e516
Merge branch 'upgrade-node-fetch' of github.com:googleapis/gaxios int…
d-goog 9164b87
test: Adopt `Headers` type from merge
d-goog d01ecde
Merge branch 'upgrade-node-fetch' of github.com:googleapis/gaxios int…
d-goog 84faea8
feat: Introduce `GaxiosOptionsPrepared` for improved type guarantees
d-goog 4e6de5f
feat: Ensure `GaxiosOptionsPrepared.url` is always a `URL`
d-goog e6c2371
refactor: Clean-up Types & Resolve lint warnings
d-goog 2089d83
Merge branch 'upgrade-node-fetch' of github.com:googleapis/gaxios int…
d-goog 98f7009
refactor: streamline `.data` for `Response`
d-goog e66c4ba
Merge branch 'upgrade-node-fetch' of github.com:googleapis/gaxios int…
d-goog 4894e39
docs: Simplify example
d-goog a7e2e83
refactor: streamline, no error case
d-goog 0baab44
Merge branch 'main' of github.com:googleapis/gaxios into do-not-treat…
d-goog b2ec395
docs: clarification
d-goog 8413f68
feat: Basic `GET` Support for `Request` objects
d-goog 04e264d
test: remove `.only`
d-goog d163a90
refactor: simplify `httpMethodsToRetry`
d-goog 705fad3
chore: update `nock`
d-goog 9e52755
test: cleanup
d-goog e5baa94
Merge branch 'upgrade-node-fetch' into do-not-treat-buffer-as-json
d-goog 0eb8882
Merge branch 'main' of github.com:googleapis/gaxios into do-not-treat…
d-goog 948a7d4
test: add test for asserting no default `content-type`
d-goog f91ae28
Merge branch 'main' of github.com:googleapis/gaxios into do-not-treat…
d-goog bbd56f2
docs: Add detail for `code` property
d-goog df3565f
docs: uniform
d-goog 9df83c3
Merge branch 'main' of github.com:googleapis/gaxios into do-not-treat…
d-goog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we write a test that asserts the behavior for what happens if a buffer does get sent in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it’s mostly a partial revert of:
but that can be added.