-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Headers should be Headers
#653
Conversation
…o upgrade-node-fetch
`node-fetch` does not yet support webstreams, which is required for `.body` node-fetch/node-fetch#387
Warning: This pull request is touching the following templated files:
|
This, along with #600 and #621 are going to cause breaking changes in auth + google-api-nodejs-client (and any other dependents). Since we don't have that level of integration tests, I'd strongly recommend releasing an experimental version of this library manually once you've merged all the breaking changes (but without merging the actual new release) and seeing what breaks in auth and GANC. That way you can preview breaking tests and any other changes, and you can revert anything if necessary before we release a new version of gaxios. In the future though, we would ideally just have these tests connected. |
Headers should be
Headers
:{}
objectsRequest#headers
Migration Guide
Simply pass non-
Headers
intoHeaders
.old:
new:
Background
🦕