Skip to content

Commit

Permalink
fix: BaseClientService.UniverDomain setter is obsolete.
Browse files Browse the repository at this point in the history
This was exposed by accident and never had any effect.

Closes b/339887021
  • Loading branch information
amanda-tarafa committed Nov 5, 2024
1 parent 948b037 commit 2043b60
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion Src/Support/Google.Apis/Services/BaseClientService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@ protected BaseClientService(Initializer initializer)
ApiKey = initializer.ApiKey;
ApplicationName = initializer.ApplicationName;
BaseUriOverride = initializer.BaseUri;
#pragma warning disable CS0618 // We still need to initialize the value on construction but the setter is rightly obsolete.
UniverseDomain = initializer.UniverseDomain;
#pragma warning restore CS0618 // Type or member is obsolete
HttpClientTimeout = initializer.HttpClientTimeout;
ValidateParameters = initializer.ValidateParameters;
if (ApplicationName == null)
Expand Down Expand Up @@ -220,7 +222,14 @@ protected BaseClientService(Initializer initializer)
/// is set, in which case <see cref="BaseUriOverride"/> will be used without further modification.
/// </para>
/// </remarks>
public string UniverseDomain { get; set; }
public string UniverseDomain
{
get;
[Obsolete(
"Using this setter never had any effect, the UniverseDomain value is used on Client construction only. " +
"Build a new Client specifying a new universe domain value instead.")]
set;
}

/// <summary>
/// The timeout to set on <see cref="HttpClient"/> instances used by the service.
Expand Down

0 comments on commit 2043b60

Please sign in to comment.