fix: check []bytes > 0 instead of nil (#2667)

Fixes: #2647
googleapis · Jul 2, 2024 · 711eb91 · 711eb91
1 parent e84fa65
commit 711eb91
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/creds.go b/internal/creds.go
@@ -127,7 +127,7 @@ func baseCreds(ctx context.Context, ds *DialSettings) (*google.Credentials, erro
 	if ds.Credentials != nil {
 		return ds.Credentials, nil
 	}
-	if ds.CredentialsJSON != nil {
+	if len(ds.CredentialsJSON) > 0 {
 		return credentialsFromJSON(ctx, ds.CredentialsJSON, ds)
 	}
 	if ds.CredentialsFile != "" {

diff --git a/internal/settings.go b/internal/settings.go
@@ -126,7 +126,7 @@ func (ds *DialSettings) Validate() error {
 	if ds.Credentials != nil {
 		nCreds++
 	}
-	if ds.CredentialsJSON != nil {
+	if len(ds.CredentialsJSON) > 0 {
 		nCreds++
 	}
 	if ds.CredentialsFile != "" {