Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add expires_in to default token callback #1932

Merged
merged 5 commits into from
Sep 18, 2020
Merged

fix: add expires_in to default token callback #1932

merged 5 commits into from
Sep 18, 2020

Conversation

bshaffer
Copy link
Contributor

expires_in is used by isAccessTokenExpired, and without it the callback, while it updates the token in memory, will refresh the token on every call to authorize

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2020
@bshaffer bshaffer requested a review from a team September 11, 2020 21:40
@bshaffer bshaffer merged commit f441bcf into master Sep 18, 2020
@bshaffer bshaffer deleted the add-expires-in-to-token-callback branch September 18, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @jdpedrie