Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add caching for GCE and access tokens by default #1935

Merged
merged 16 commits into from
Oct 23, 2020
Merged

feat: add caching for GCE and access tokens by default #1935

merged 16 commits into from
Oct 23, 2020

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Sep 12, 2020 •
edited
Loading

  • Passes cache to calls to ApplicationDefaultCredentials::getCredentials to take advantage of new onGce cache
  • Wraps credentials in FetchAuthTokenCache on calls to ApplicationDefaultCredentials::fetchAccessTokenWithAssertion

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2020
@bshaffer bshaffer changed the title feat: add caching for GCE and access tokens by default - Passes cache to calls to ApplicationDefaultCredentials::getCredentials to take advantage of new onGce cache - Wraps credentials in FetchAuthTokenCache on calls to ApplicationDefaultCredentials::fetchAccessTokenWithAssertion feat: add caching for GCE and access tokens by default Sep 12, 2020
@bshaffer bshaffer requested a review from a team September 14, 2020 17:45
@bshaffer
Copy link
Contributor Author

depends on a fix in https://github.com/googleapis/google-api-php-client/pull/1968/files which somehow passed when we added namespaces

@bshaffer bshaffer merged commit b39ee32 into master Oct 23, 2020
@bshaffer bshaffer deleted the add-caching-by-default branch October 23, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @jdpedrie