Issue 1965 - Exceptions option fallback to http_errors on guzzle 6 or 7

[sylvain-msl]

Misc

Fix for #1964

Changes

Updates

• default options exceptions changed to http_errors when guzzle version is 6 or 7. (The deprecation of exceptions was implemented in guzzle 6 and enforced in guzzle 7).

[bshaffer]

Thank you for your contribution! I cleaned up the submission a bit to make it more readable w/o changing the functionality. If you can make these changes then we can merge this.

[bshaffer]

Seems like we should just remove the setting of exceptions above and do the following instead for more obvious/straightforward logic:

if (5 === $guzzleVersion) {
  $options = [
    'base_url' => $this->config['base_path'],
    'defaults' => ['exceptions' => false],
  ];
  if ($this->isAppEngine()) {
    // set StreamHandler on AppEngine by default
    $options['handler'] = new StreamHandler();
    $options['defaults']['verify'] = '/etc/ca-certificates.crt';
  }
} elseif (6 === $guzzleVersion || 7 === $guzzleVersion) {
  // guzzle 6 or 7
  $options[
    'base_uri' => $this->config['base_path'],
    'http_errors' => false,
  ];
} else {
  throw new LogicException('Could not find supported version of Guzzle.');
}

[sylvain-msl]

Done. It makes more sense indeed. Thanks for your feedback.

[bshaffer]

Thank you for your contribution!