-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for PHP 8.2 ✨ #2359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, but you're making a lot of changes here that we either don't want, are covered by #2350, or are confusing to me.
The only changes here I think we would need are:
- Upgrading nickinvision to v2 (why not?)
- Updating
.github/sync-repo-settings.yaml
, although we don't need to add all the prefer lowest / stables - Potentially adding
ReturnTypeWillChange
toGoogle\Collection
, although if this is a problem then I'm surprised that hasn't been reported elsewhere, and if so it still should be in a separate PR.
The changes I don't want here are:
- expanding the matrix to run prefer-lowest in every case
- adding all those extensions to the PHP build
- adding the plugin to composer.json (why?)
- running the CI on feature branches
|
|
|
These items will be addressed in #2431 |
Main changes