Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: php 8.3 deprecated get_class method call without argument #2509

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

AmooAti
Copy link
Contributor

@AmooAti AmooAti commented Oct 10, 2023

Hi,

In this PR, I replaced get_class with self:class due to new deprecations in PHP 8.3, which you can read about it here

Since PHP 8.3 is still an RC version, Many things, like upgrading composer packages, need to be done to be compatible with PHP 8.3, but this is a code issue and can be solved right now.

@AmooAti AmooAti requested a review from a team as a code owner October 10, 2023 14:55
@google-cla
Copy link

google-cla bot commented Oct 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ldebrouwer
Copy link

Just chiming in that this is blocking my team from upgrading our production systems to PHP 8.3 as well.

@bshaffer
Copy link
Contributor

I'm not sure why the tests aren't running for this.

@bshaffer
Copy link
Contributor

Unfortunately we are frozen until January 2nd, so we can't release this fix until then. You cau use dev-main in the meantime at your own risk

@parallels999
Copy link

Ok thanks, that will be very helpful 👍

@bshaffer bshaffer merged commit 8c66021 into googleapis:main Dec 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants