Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass library and Python version in x-goog-api-client #734

Merged
merged 6 commits into from
Aug 9, 2019
Merged

Pass library and Python version in x-goog-api-client #734

merged 6 commits into from
Aug 9, 2019

Conversation

busunkim96
Copy link
Contributor

Closes #729

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2019
@busunkim96 busunkim96 requested a review from dazuma August 5, 2019 20:16
busunkim96
busunkim96 commented Aug 5, 2019
View reviewed changes
googleapiclient/model.py Outdated Show resolved Hide resolved
dazuma
dazuma reviewed Aug 5, 2019
View reviewed changes
tests/test_json_model.py Outdated Show resolved Hide resolved
tests/test_http.py Outdated Show resolved Hide resolved
@busunkim96 busunkim96 requested a review from a team August 5, 2019 23:49
AlanGasperini
AlanGasperini reviewed Aug 9, 2019
View reviewed changes
googleapiclient/model.py Show resolved Hide resolved
tests/test_json_model.py Show resolved Hide resolved
@busunkim96 busunkim96 merged commit 07f647c into googleapis:master Aug 9, 2019
@vorpal-buildbot vorpal-buildbot mentioned this pull request Aug 13, 2019
Merged
@asiunov
Copy link

asiunov commented Aug 13, 2019 •
edited
Loading

@busunkim96 @tseaver @dazuma
seems like this PR introduces some regression. I started to get a signature mismatch when use this sdk (on .get_media method):

W0813 19:40:45.663586 1 http.py:118] Invalid JSON content from response: b"<?xml version='1.0' encoding='UTF-8'?><Error><Code>SignatureDoesNotMatch</Code><Message>The request signature we calculated does not match the signature you provided. Check your Google secret key and signing method.</Message><StringToSign>GET\n\n\n1565725545\nx-goog-api-client:gdcl/1.7.11 gl-python/3.7.4\n/...</StringToSign></Error>"

@busunkim96
Copy link
Contributor Author

@asiunov Thank you for the report! Could you let us know which API you are using? (A small sample would also be much appreciated).

I see a similar error mentioned for node, but am unsure if this is the same cause.

@asiunov asiunov mentioned this pull request Aug 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGasperini AlanGasperini AlanGasperini left review comments

@tswast tswast tswast left review comments

@tseaver tseaver tseaver approved these changes

@dazuma dazuma dazuma approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure client is reporting Python version
7 participants
@busunkim96 @asiunov @dazuma @tseaver @tswast @AlanGasperini @googlebot