chore: use ImpersonatedCredentials for service account impersonation for 3pi #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in ExternalAccountCredentials
google-cla
bot
added
the
cla: yes
chingor13
requested changes
Oct 26, 2020
chingor13
approved these changes
Oct 29, 2020
chingor13
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the service_account_impersonation_url is provided, we must exchange the external account GCP access token for a service account impersonated token.
This PR removes the duplicated code in ExternalAccountCredentials that makes the IAM generateAccessToken call and delegates it to ImpersonatedCredentials.