Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow custom scopes for compute engine creds #514

Merged
merged 4 commits into from
Dec 16, 2020
Merged

feat: allow custom scopes for compute engine creds #514

merged 4 commits into from
Dec 16, 2020

Conversation

arithmetic1728
Copy link
Contributor

Fixes #458

@arithmetic1728 arithmetic1728 requested a review from a team as a code owner December 9, 2020 22:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #514 (699942d) into master (5e49463) will increase coverage by 0.06%.
The diff coverage is 86.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #514      +/-   ##
============================================
+ Coverage     79.91%   79.97%   +0.06%     
- Complexity      413      419       +6     
============================================
  Files            28       28              
  Lines          1947     1963      +16     
  Branches        203      207       +4     
============================================
+ Hits           1556     1570      +14     
- Misses          283      284       +1     
- Partials        108      109       +1
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 83.89% <86.36%> (+0.43%) 35.00 <9.00> (+6.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e49463...699942d. Read the comment docs.

@arithmetic1728
Copy link
Contributor Author

The format/format-code check failure is not related to this PR. It seems something is wrong with the /home/runner/work/_actions/googleapis/code-suggester/v1.8.0/Dockerfile docker build.

@silvolu silvolu requested a review from chingor13 December 14, 2020 19:28
@silvolu
Copy link

silvolu commented Dec 14, 2020

Jeff, Elliot, recently updated AIP for this at https://google.aip.dev/auth/4115

@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2020
@arithmetic1728 arithmetic1728 merged commit edc8d6e into master Dec 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2020
@arithmetic1728 arithmetic1728 deleted the add_scopes branch December 16, 2020 22:24
@chingor13 chingor13 mentioned this pull request Dec 16, 2020
Closed
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 26, 2021
@release-please
chore: release 0.23.0 (#525)
c76766e 
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.23.0](https://www.github.com/googleapis/google-auth-library-java/compare/v0.22.2...v0.23.0) (2021-01-26)


### ⚠ BREAKING CHANGES

* privatize deprecated constructor (#473)

### Features

* allow custom lifespan for impersonated creds ([#515](https://www.github.com/googleapis/google-auth-library-java/issues/515)) ([0707ed4](https://www.github.com/googleapis/google-auth-library-java/commit/0707ed4bbb40fb775f196004ee30f8c695fe662b))
* allow custom scopes for compute engine creds ([#514](https://www.github.com/googleapis/google-auth-library-java/issues/514)) ([edc8d6e](https://www.github.com/googleapis/google-auth-library-java/commit/edc8d6e0e7ca2c6749d026ba42854a09c4879fd6))
* allow set lifetime for service account creds ([#516](https://www.github.com/googleapis/google-auth-library-java/issues/516)) ([427f2d5](https://www.github.com/googleapis/google-auth-library-java/commit/427f2d5610f0e8184a21b24531d2549a68c0b546))
* promote IdToken and JWT features ([#538](https://www.github.com/googleapis/google-auth-library-java/issues/538)) ([b514fe0](https://www.github.com/googleapis/google-auth-library-java/commit/b514fe0cebe5a294e0cf97b7b5349e6a523dc7b2))


### Bug Fixes

* per google style, logger is lower case ([#529](https://www.github.com/googleapis/google-auth-library-java/issues/529)) ([ecfc6a2](https://www.github.com/googleapis/google-auth-library-java/commit/ecfc6a2ea6060e06629b5d422b23b842b917f55e))
* privatize deprecated constructor ([#473](https://www.github.com/googleapis/google-auth-library-java/issues/473)) ([5804ff0](https://www.github.com/googleapis/google-auth-library-java/commit/5804ff03a531268831ac797ab262638a3119c14f))
* remove deprecated methods ([#537](https://www.github.com/googleapis/google-auth-library-java/issues/537)) ([427963e](https://www.github.com/googleapis/google-auth-library-java/commit/427963e04702d8b73eca5ed555539b11bbe97342))
* replace non-precondition use of Preconditions ([#539](https://www.github.com/googleapis/google-auth-library-java/issues/539)) ([f2ab4f1](https://www.github.com/googleapis/google-auth-library-java/commit/f2ab4f14262d54de0fde85494cfd92cf01a30cbe))
* switch to GSON ([#531](https://www.github.com/googleapis/google-auth-library-java/issues/531)) ([1b98d5c](https://www.github.com/googleapis/google-auth-library-java/commit/1b98d5c86fc5e56187c977e7f43c39bb62483d40))
* use default timeout if given 0 for ImpersonatedCredentials ([#527](https://www.github.com/googleapis/google-auth-library-java/issues/527)) ([ec74870](https://www.github.com/googleapis/google-auth-library-java/commit/ec74870c372a33d4157b45bb5d59ad7464fb2238))


### Dependencies

* update dependency com.google.appengine:appengine-api-1.0-sdk to v1.9.84 ([#422](https://www.github.com/googleapis/google-auth-library-java/issues/422)) ([b262c45](https://www.github.com/googleapis/google-auth-library-java/commit/b262c4587b058e6837429ee05f1b6a63620ee598))
* update dependency com.google.guava:guava to v30.1-android ([#522](https://www.github.com/googleapis/google-auth-library-java/issues/522)) ([4090d1c](https://www.github.com/googleapis/google-auth-library-java/commit/4090d1cb50041bceb1cd975d1a9249a412df936f))


### Documentation

* fix wording in jwtWithClaims Javadoc ([#536](https://www.github.com/googleapis/google-auth-library-java/issues/536)) ([af21727](https://www.github.com/googleapis/google-auth-library-java/commit/af21727815263fb5ffc07ede953cf042fac3ac2b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
@amanda-tarafa amanda-tarafa mentioned this pull request Apr 19, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
@westarle westarle mentioned this pull request Feb 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo left review comments

@silvolu silvolu silvolu approved these changes

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users can't specify non-default scopes for code running on GKE Workload Identity (and possibly AppEngine flex)
4 participants
@arithmetic1728 @silvolu @chingor13 @elharo