refactor(samples): idtoken-cloudrun => idtoken-serverless

[grayside]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #1019 🦕

I did not see instructions on how to run the sample tests, so going to see what CI has to say.

[codecov]

Codecov Report

Merging #1025 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          21       21           
  Lines        4093     4093           
  Branches      488      488           
=======================================
  Hits         3746     3746           
  Misses        347      347           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e5701...724f62e. Read the comment docs.

[grayside]

Not clear how to run the lint/fix locally, and from this result I cannot tell what change is needed:

##[error]  41:18  error  Replace `⏎······`request·${url}·with·target·audience·${targetAudience}`⏎····` with ``request·${url}·with·target·audience·${targetAudience}``  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

I see the docs test failure, but I don't see other references within this repo and thus do not know where I need to make other changes:

[404] https://github.com/googleapis/google-auth-library-nodejs/blob/master/samples/idtokens-serverless.js


http://localhost:5758/
  [404] https://github.com/googleapis/google-auth-library-nodejs/blob/master/samples/idtokens-serverless.js
ERROR: Detected 1 broken links. Scanned 51 links in 1.649 seconds.

[JustinBeckwith]

LGTM, after linting issues are resolved

[JustinBeckwith]

@grayside for the sample tests, npm run samples-test should get you where you want to go :)
https://github.com/googleapis/google-auth-library-nodejs/blob/master/CONTRIBUTING.md#running-the-tests

If that doesn't work, let us know we'll update the guide!

[grayside]

Ah, when I ran npm run fix I saw no output about fixes made and assumed nothing was done, but I see a change!

For npm run samples-test, I don't have access to the project used in this repo and don't see instructions on all the GCP resources that need to be setup. I'll fix the lint and we'll see what happens.

[grayside]

Sample test was failing then went to passing. I assume there's some magic afoot...

[bcoe]

@grayside there's a chicken or the egg issue, where the link checker expects your sample to have already been landed:

  [404] https://github.com/googleapis/google-auth-library-nodejs/blob/master/samples/idtokens-serverless.js

If you add an ignore rule to linkinator.config.json for the above URL, we can then immediately revert that change once we land your work.

[JustinBeckwith]

If you're ok with this to be merged, I can also just hammer merge it.

[grayside]

That works for me. Btw, not sure how it works, but shouldn't I be the assignee? I have no rights here.