-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default self-signed JWTs #1054
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 91.52% 91.70% +0.17%
==========================================
Files 21 21
Lines 4094 4145 +51
Branches 488 497 +9
==========================================
+ Hits 3747 3801 +54
+ Misses 347 344 -3
Continue to review full report at Codecov.
|
This looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is ready for review, when it comes time to integrate, the plan is that:
gax-nodejs
will use thekDefaultScopes
symbol to provide a default set of scopes. This allows us to differentiate between user-defined and gax-defined scopes, while discouraging users from setting the key themselves (as you need to go out of your way to do so.).gax-nodejs
will populatescopes
rather thankDefaultScopes
if an alternateservicePath
has been set.
Note: there's an ongoing discussion about simpler audience strings (this feature will be implemented in a future PR.).
Update: I ended up simplifying the implementation and going back to a string, based on Alex's feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. Looks great! Mostly just questions.
Should |
I had missed setting |
Start using self signed JWTs for client libraries when:
This will require upstream work in the client libraries to begin populating
defaultScopes
rather thanscopes
.