-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: workload identity federation support #1131
Changes from 21 commits
3f1368d
7f8b124
1174e4a
424755c
bbcd03d
26ab5e3
3020c6f
b7075e9
150740e
d759b09
291652a
b8f14ec
317b1d2
8f657ce
ec84e81
31b9cfb
ba91949
161983e
42b0605
7385313
9b44aa7
0723ade
954cefa
d5645e6
2e75989
6f06cb3
dfb68ea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ | |
"client library" | ||
], | ||
"dependencies": { | ||
"12": "^1.0.2", | ||
bcoe marked this conversation as resolved.
Show resolved
Hide resolved
bcoe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"arrify": "^2.0.0", | ||
"base64-js": "^1.3.0", | ||
"ecdsa-sig-formatter": "^1.0.11", | ||
|
@@ -29,6 +30,8 @@ | |
}, | ||
"devDependencies": { | ||
"@compodoc/compodoc": "^1.1.7", | ||
"@microsoft/api-documenter": "^7.8.10", | ||
"@microsoft/api-extractor": "^7.8.10", | ||
"@types/base64-js": "^1.2.5", | ||
"@types/chai": "^4.1.7", | ||
"@types/jws": "^3.1.0", | ||
|
@@ -67,9 +70,7 @@ | |
"ts-loader": "^8.0.0", | ||
"typescript": "^3.8.3", | ||
"webpack": "^4.20.2", | ||
"webpack-cli": "^4.0.0", | ||
"@microsoft/api-documenter": "^7.8.10", | ||
"@microsoft/api-extractor": "^7.8.10" | ||
"webpack-cli": "^4.0.0" | ||
}, | ||
"files": [ | ||
"build/src", | ||
|
@@ -84,6 +85,7 @@ | |
"fix": "gts fix", | ||
"pretest": "npm run compile", | ||
"docs": "compodoc src/", | ||
"samples-setup": "cd samples/ && npm link ../ && npm run setup && cd ../", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this seems like a reasonable addition to the script, presumably so that you could setup the sample environment outside of running tests? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes that is correct. This is very useful if you want to set up the sample environment in a different project or locally. |
||
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../", | ||
"system-test": "mocha build/system-test --timeout 60000", | ||
"presystem-test": "npm run compile", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a massive addition to the README, and I worry a little about the size. I am ok keeping it here for now (non-blocking feedback), but we need a better documentation strategy for auth. @tbpg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcoe also pointed out the same issue which I agree with. There are larger plans to update the official authentication docs: https://cloud.google.com/docs/authentication. Though this could be delayed until Q3. Currently, they are only updating the workload identity federation docs:
It would be a good idea to align with the overall documentation effort in the cloud docs and the GitHub repos.