-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add External Account Authorized User client type #1530
Merged
aeitzman
merged 11 commits into
googleapis:main
from
aeitzman:external-account-authorized-user
Apr 13, 2023
Merged
feat: Add External Account Authorized User client type #1530
aeitzman
merged 11 commits into
googleapis:main
from
aeitzman:external-account-authorized-user
Apr 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeitzman
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 13, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 13, 2023
lsirac
reviewed
Apr 10, 2023
Looks like this PR has additional comments that need to be addressed before we can merge. |
lsirac
approved these changes
Apr 11, 2023
danielbankhead
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few minor/optional changes
Co-authored-by: Daniel Bankhead <dan@danielbankhead.com>
aeitzman
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Apr 12, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 12, 2023
yoshi-kokoro
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Apr 12, 2023
aeitzman
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Apr 12, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kokoro:run
Add this label to force Kokoro to re-run the tests.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for external account authorized user credentials.
See go/gcloud-3pi-headful.