docs(readme): add example for service_account_impersonation_url in clientOptions #1902
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…pplier The service_account_impersonation_url must be passed in the clientOptions when using a custom AwsSupplier to avoid permissions errors. Updated the README to include this information.
varun27896
force-pushed
the
customcreds-clientoptions-fix
branch
from
642a040 to
8188060
Compare
varun27896
changed the title
…als.yml Updated the .partials.yml file to include the service_account_impersonation_url configuration example, ensuring consistency with the README file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for implementing support for passing custom AWS credentials in your library. Your efforts are much appreciated.
While I was working on implementing the custom supplier, I noticed that the
service_account_impersonation_urlfield is missing from theclientOptionsobject in your documentation. Without including this field, a permissions error is thrown during execution. This PR adds that field to the README