update instance email & key properties from gToken #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
|
Coverage increased (+0.03%) to 91.95% when pulling 1f089423316d195eb812f7a2e4c37df3499d9606 on stephenplusplus:master into 97cefdd on google:master. |
| @@ -101,6 +101,8 @@ JWT.prototype.authorize = function(opt_callback) { | |||
| if (!err) { | |||
| that.credentials = result; | |||
| that.credentials.refresh_token = 'jwt-placeholder'; | |||
| that.key = that.gtoken.key; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tbetbetbe
added a commit
that referenced
this pull request
Apr 3, 2015
update instance email & key properties from gToken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given a path to a keyfile, gtoken will update its own instance with the extracted email & key data after parsing it from the file. These values are useful to expose to users, as an example, for when trying to create a signed URL for Storage access.
Ping @ryanseys to see if this is a reliable way to get these values.