fix: gcp-metadata now warns rather than throwing #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
AVaksman
approved these changes
May 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
=======================================
Coverage 92.88% 92.88%
=======================================
Files 19 19
Lines 4017 4017
Branches 481 446 -35
=======================================
Hits 3731 3731
Misses 286 286 Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguably the upstream
gcp-metadatachange, which warns rather than throwing, was breaking ... but given that these should be rare events, and our default behavior is less user-hostile now, I'm voting that it's fine to simply update this test.